Add bus routing constraint props#758
Merged
Merged
Conversation
This was referenced Jul 27, 2026
seveibar
marked this pull request as ready for review
July 27, 2026 04:36
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+1
to
+20
| import { expect, test } from "bun:test" | ||
| import { busProps, type BusProps } from "lib/components/bus" | ||
|
|
||
| test("busProps accepts two or more connection references", () => { | ||
| const rawProps: BusProps = { | ||
| name: "DATA", | ||
| connections: ["D0", ".U1 > .D1"], | ||
| } | ||
|
|
||
| expect(busProps.parse(rawProps)).toEqual(rawProps) | ||
| }) | ||
|
|
||
| test("busProps rejects a single connection", () => { | ||
| expect( | ||
| busProps.safeParse({ | ||
| name: "DATA", | ||
| connections: ["D0"], | ||
| }).success, | ||
| ).toBe(false) | ||
| }) |
Contributor
There was a problem hiding this comment.
This file contains two test(...) calls, which violates the rule that a *.test.ts file may have AT MOST one test(...). Please split this into two separate numbered files, e.g. bus1.test.ts (for 'busProps accepts two or more connection references') and bus2.test.ts (for 'busProps rejects a single connection').
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BusPropsand thebusPropsZod schemaconnectionsWhy
Autorouters need an author-facing way to identify signals that belong to the same bus. This adds the smallest declarative API needed by core without leaking router-specific tuning into component props.
Developer impact
Circuit authors can declare routing intent with:
Validation
bun run typecheckbun run buildbun test tests/bus.test.tsbun run format:check